Extend DRY support for persistence and Ingress #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Nov 28, 2024
|
Hi please bump the chart version and add a changelog entry, LGTM apart from that. A unit test would be nice to so-as to make sure this keeps working in the future, but this is a very small change |
CeddaerrixGE
suggested changes
Nov 28, 2024
|
BTW - You are missing unit tests for this implementation |
timja
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add tpl support for persistence.storageClassName in home-pvc.yaml--> Add tpl support for controller.ingress parameters(ingressClassName, annotations, hostname) in jenkins-controller-ingress.yaml
If you modified files in the
./charts/jenkins/directory, please also include the following:Submitter checklist
Special notes for your reviewer