Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix jenkins-agent renovate version regex #1285

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

kvanzuijlen
Copy link
Contributor

What does this PR do?

I found a small issue (misunderstanding on my part) in how the version numbers for Jenkins Agents work. Apparently version numbers don't always contain _ (and the split doesn't specify patch-level changes)?

  • Fixes #

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

Preview Give feedback

Special notes for your reviewer

@kvanzuijlen kvanzuijlen requested a review from a team as a code owner January 20, 2025 13:40
@kvanzuijlen
Copy link
Contributor Author

@timja How do you want to handle this error in super-linter? The configuration is correct (Renovate needs these extra escapes). Should we disable JSONC?

@timja
Copy link
Member

timja commented Jan 20, 2025

@timja How do you want to handle this error in super-linter? The configuration is correct (Renovate needs these extra escapes). Should we disable JSONC?

Yeah just disable things that don't make sense in the linter

@timja timja merged commit 6020895 into jenkinsci:main Jan 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants