Update k8s version to test on #955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
commented
Nov 26, 2023
NotMyFault
force-pushed
the
update-k8s-test-versions
branch
from
e66fbca to
92c0015
Compare
torstenwalter
requested changes
Nov 27, 2023
Comment on lines
+14
to
+16
| - "kindest/node:v1.28.4" | ||
| - "kindest/node:v1.27.8" | ||
| - "kindest/node:v1.26.11" |
There was a problem hiding this comment.
The specified versions do not exist. See https://hub.docker.com/r/kindest/node/tags
These kind of changes are a bit tricky as CI might trick you. chart-testing (ct) only checks changed charts. As you don't update the chart version it skips most of the tests and the build seems to be green.
What I often did is creating a draft PR, which bumps the chart version on top of changes like this to verify that everything is OK. See #957 as an example. Feel free to charry-pick the versions from there.
NotMyFault
force-pushed
the
update-k8s-test-versions
branch
from
92c0015 to
3d55044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.