Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prometheus docs mentioning master as config field that has been … #963

Closed
wants to merge 1 commit into from

Conversation

Hillkorn
Copy link

@Hillkorn Hillkorn commented Dec 5, 2023

…renamed to controller

What does this PR do?

  • Fixes the documentation of the fields mentioned in the prometheus montitor

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

Preview Give feedback

Special notes for your reviewer

I think none of the above tasks is required by that config documentation change

@Hillkorn Hillkorn requested a review from a team as a code owner December 5, 2023 14:59
@NotMyFault
Copy link
Member

@Hillkorn Please take a look at the PR submitter checklist.

@Hillkorn
Copy link
Author

Hillkorn commented Jan 9, 2024

@Hillkorn Please take a look at the PR submitter checklist.

Is it even required for such a documentation update? I guess it was missed during the renaming of the config field master -> controller . I used the wrong field name because of this and then looked it up in the helm templates to find out that the field name is different. The change is also in the changelog but the documentation still uses the old name.

@timja
Copy link
Member

timja commented Jan 9, 2024

@Hillkorn Please take a look at the PR submitter checklist.

Is it even required for such a documentation update? I guess it was missed during the renaming of the config field master -> controller . I used the wrong field name because of this and then looked it up in the helm templates to find out that the field name is different. The change is also in the changelog but the documentation still uses the old name.

anything that changes something in the chart folder requires a bump currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants