Add multi-cloud support (#634) #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Dec 18, 2023
| @@ -206,6 +207,94 @@ jenkins: | |||
| {{- end }} | |||
| {{- end }} | |||
| {{- end }} | |||
| {{- if .Values.additionalClouds }} | |||
There was a problem hiding this comment.
could you add a unit test for this please?
https://github.com/jenkinsci/helm-charts/blob/main/CONTRIBUTING.md#unit-tests
timja
reviewed
Dec 18, 2023
added 3 commits
December 18, 2023 14:55
…arts into feature-multi-cloud
|
Wow! This review was fast ⚡ Thanks! |
|
I see now some IDs in the tests are failing. And the other error is regarding the jenkins-agent image tag. I'll fix those and push the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
credentialsIdfor the main cloud and the additional clouds.If you modified files in the
./charts/jenkins/directory, please also include the following:Submitter checklist
Special notes for your reviewer
I did not do the tasks in "Submitter checklist" because I want to gather feedback on my changes. If I'm going in the right direction I will be happy to do all those tasks!
I tried to do the
additionalCloudsfeature the same way theadditionalAgentsfeature was built in: by looping through the items and merging to the main template. I also stored the state before the loop and restored it after the loop ends.