Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add derive macro to strip enum of data #39
Add derive macro to strip enum of data #39
Changes from 32 commits
030d866
f038775
923fe56
308254d
8822de7
145297a
50720a8
107e190
11f1dbb
dd3e75b
c967b81
71fe83a
5c56d07
21b0b3e
4ddac45
bc8b714
5a32040
5103330
11b45f1
6cd39ae
d36d436
33bc53a
cea85c5
e6bda77
29c4b82
bdd2808
4ab8954
d513acf
27a5075
9d8a461
6f634db
722cdf5
fd88940
53cdd70
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Inheritance functionality is commented out and needs implementation
Based on the code inspection:
strip_enum.rs
(visible in the commented block containinginherit
logic)EnumWithInherit
expecting this functionalityThis confirms the original review comment's observation. The feature is incomplete as the implementation is commented out while the test exists.
🔗 Analysis chain
Verify inheritance functionality implementation.
The test case exists for enum inheritance, but the corresponding implementation appears to be commented out in
strip_enum.rs
(lines 122-139). Either implement the inheritance functionality or remove the test case.Let me check the implementation details in the
strip_enum.rs
file.Let me check if there are any active implementations or tests related to inheritance functionality.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 48
Script:
Length of output: 915
Script:
Length of output: 780