Respect property https.protocols #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API's are disabling TLS v1 in favor of the more secure protocols TLS 1.1 or TLS 1.2. Java has a system property for setting this, https.protocols, that this library completely ignores. Updating the library so that this property is used to set the transport protocols. Upgrading http-client version to 4.5.2 for the SSLConnectionSocketFactory builder Fixing testRedirect() - google redirects http - https now Fixes issue jgritman#56
|
Thanks for this @kairas! Testing the jar built from your fork now. |
jja
added a commit
to NCAR/httpbuilder
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API's are disabling TLS v1 in favor of the more secure protocols TLS 1.1 or TLS 1.2. Java has a system property for setting this, https.protocols, that this library completely ignores. Updating the library so that this property is used to set the transport protocols.
Upgrading http-client version to 4.5.2 for the SSLConnectionSocketFactory builder
Fixing testRedirect() - google redirects http - https now
Fixes issue #56