jgrss/reorg #319
Open
jgrss/reorg #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrss
commented
May 18, 2024
| @@ -40,18 +46,32 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def transform_from_corner( | |||
jgrss
commented
May 18, 2024
|
|
||
| return height, width | ||
| return window_from_bounds(*bounds, transform=transform) |
jgrss
commented
May 18, 2024
|
|
||
| @check_chunks.register | ||
| def _(chunks: tuple) -> dict: | ||
| return dict( |
There was a problem hiding this comment.
This addresses an Xarray deprecation warning.
Closed
|
@mmann1123 this addresses #311. I commented on the relevant changes. |
mmann1123
approved these changes
May 21, 2024
| mode (Optional[str]): The file storage mode. Choices are ['w', 'r+']. | ||
| nodata (Optional[float | int]): The 'no data' value. If ``None`` (default), the 'no data' | ||
| value is taken from the ``DataArray`` metadata. | ||
| scatter (Optional[str]): Scatter 'band' or 'time' to separate file. Default is None. |
There was a problem hiding this comment.
@jgrss I am not sure what you mean here. Does it create a new file for each band?
| @@ -208,7 +216,7 @@ def _download_worker(item, extra: str, out_path: _Path) -> dict: | |||
|
|
|||
|
|
|||
| def open_stac( | |||
There was a problem hiding this comment.
Stack is still new to me but at some point we need to bring this into the tutorials in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR changing?
Fixes
open()height/width results following #311