Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client configs #383

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement client configs #383

wants to merge 1 commit into from

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Jan 1, 2025

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 78.26087% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.07%. Comparing base (b9bba17) to head (639c569).

Files with missing lines Patch % Lines
internal/config/validate.go 10.00% 6 Missing and 3 partials ⚠️
internal/openvpn/callbacks.go 75.75% 6 Missing and 2 partials ⚠️
cmd/daemon/root.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   83.15%   83.07%   -0.09%     
==========================================
  Files          50       50              
  Lines        2856     2913      +57     
==========================================
+ Hits         2375     2420      +45     
- Misses        367      375       +8     
- Partials      114      118       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant