feat: add ability to pass NestApplicationContextOptions to CommandFac…

…toryRunOptions (#914)
jmcdo29 · Jun 10, 2023 · daeb36d · daeb36d
2 parents 2c83a52 + 6cc1112
commit daeb36d
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 33 deletions.
diff --git a/.changeset/moody-books-battle.md b/.changeset/moody-books-battle.md
@@ -0,0 +1,8 @@
+---
+'nest-commander': minor
+---
+
+Add ability to pass NestApplicationContextOptions to CommandFactoryRunOptions.
+
+Now CommandFactory.createWithoutRunning() can accept more options, for example,
+bufferLogs to pre-save Nest startup logs.
diff --git a/packages/nest-commander/src/command-factory.interface.ts b/packages/nest-commander/src/command-factory.interface.ts
@@ -1,4 +1,5 @@
 import { LoggerService, LogLevel } from '@nestjs/common';
+import { NestApplicationContextOptions } from '@nestjs/common/interfaces/nest-application-context-options.interface';
 
 export type ErrorHandler = (err: Error) => void;
 export type NestLogger = LoggerService | LogLevel[] | false;
@@ -9,7 +10,8 @@ export interface DefinedCommandFactoryRunOptions
   usePlugins: boolean;
 }
 
-export interface CommandFactoryRunOptions {
+export interface CommandFactoryRunOptions
+  extends NestApplicationContextOptions {
   logger?: NestLogger;
   errorHandler?: ErrorHandler;
   usePlugins?: boolean;

diff --git a/packages/nest-commander/src/command.factory.ts b/packages/nest-commander/src/command.factory.ts
@@ -48,9 +48,7 @@ export class CommandFactory {
     });
     const app = await NestFactory.createApplicationContext(
       commandRunnerModule,
-      {
-        logger: options.logger,
-      },
+      options,
     );
     return app;
   }
@@ -76,35 +74,24 @@ export class CommandFactory {
   protected static getOptions(
     optionsOrLogger: CommandFactoryRunOptions | NestLogger,
   ): DefinedCommandFactoryRunOptions {
-    let logger: NestLogger | undefined;
-    let tempHandler: ((err: Error) => void) | undefined;
-    let usePlugins = false;
-    let cliName = 'nest-commander';
-    let serviceErrorHandler = undefined;
-    let enablePositionalOptions = false;
-    let enablePassThroughOptions = false;
-    if (this.isFactoryOptionsObject(optionsOrLogger)) {
-      ({
-        logger,
-        errorHandler: tempHandler,
-        cliName = cliName,
-        usePlugins = usePlugins,
-        serviceErrorHandler,
-        enablePositionalOptions = enablePositionalOptions,
-        enablePassThroughOptions = enablePassThroughOptions,
-      } = optionsOrLogger);
-    } else {
-      logger = optionsOrLogger;
-    }
-    return {
-      logger,
-      errorHandler: tempHandler,
-      usePlugins,
-      cliName,
-      serviceErrorHandler,
-      enablePositionalOptions,
-      enablePassThroughOptions,
-    };
+    let options: CommandFactoryRunOptions = {};
+    const isOptionsIsFactoryOptionsObject =
+      this.isFactoryOptionsObject(optionsOrLogger);
+    options = isOptionsIsFactoryOptionsObject ? optionsOrLogger : options;
+
+    options.logger =
+      (isOptionsIsFactoryOptionsObject
+        ? (optionsOrLogger as CommandFactoryRunOptions).logger
+        : (optionsOrLogger as NestLogger)) || false;
+    options.errorHandler = options.errorHandler || undefined;
+    options.usePlugins = options.usePlugins || false;
+    options.cliName = options.cliName || 'nest-commander';
+    options.serviceErrorHandler = options.serviceErrorHandler || undefined;
+    options.enablePositionalOptions = options.enablePositionalOptions || false;
+    options.enablePassThroughOptions =
+      options.enablePassThroughOptions || false;
+
+    return options as DefinedCommandFactoryRunOptions;
   }
 
   protected static isFactoryOptionsObject(