Add fallback cover #1002
Open
Add fallback cover #1002
+42
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enables naturally falling back to Finamp's default blue as accent color - hopefully fixes crashes on some System UIs in Android 10 and below (https://issuetracker.google.com/issues/278918062)
|
Not sure if the merge is correct, didn't test it yet. Also not sure if this even fixes the issue of blank player screens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old experimental branch, but since missing covers still result in a blank player screen with gray accent color, I thought it probably won't hurt to add this in.
The placeholder can be improved later on, once we know that it actually works.