Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated countries.geo.json to include Singapore #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated countries.geo.json to include Singapore #40

wants to merge 3 commits into from

Conversation

honcheng
Copy link

@honcheng honcheng commented Dec 20, 2016 •
edited
Loading

Also edited polygon for Malaysia. Previously polygon for Malaysia incorrectly included Singapore

@novalagung
Copy link

just curious why this PR is not merged yet

@iamjoyce
Copy link

(FYI) This is how the polygon looks like for Singapore

singapore-polygon

@coolguyvarun01
Copy link

Location seems right.

@johan
Copy link
Owner

johan commented Nov 19, 2017

FWIW: this repository holds (low-resolution) country coastline coordinates for all countries in the edited countries.geo.json, and each such country as a separate file named after the id of each said country polygon, so drawing either on a map will be the visual shape of that country, not some kind of territorial claim to waters. This PR wrecks both of those constraints, and edits far more than it claims:

sgp mys

@emiliano1
Copy link

Does anyone know how I can change the "Multipolygon" to "polygon"? I do not think is a simple CTRL+F situation.

@kdeasymoneysniper
Copy link

Hi, can I check where the Singapore.geo.json file is located? I cant seem to find it within the files. Thanks!

paulkaefer added a commit to paulkaefer/read-the-world that referenced this pull request Jul 25, 2020
@paulkaefer
WIP code & webpage;
24f7eca 
Singapore JSON via johan/world.geo.json#40
@nch3ng
Copy link

nch3ng commented Dec 1, 2020

Is there any reason this hasn't been merged yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolguyvarun01 coolguyvarun01 coolguyvarun01 approved these changes

@johnpaul08 johnpaul08 johnpaul08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@honcheng @novalagung @iamjoyce @coolguyvarun01 @johan @emiliano1 @kdeasymoneysniper @nch3ng @johnpaul08