Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plasmic] Sync project Canvas App Explorer #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[plasmic] Sync project Canvas App Explorer #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions frontend/components/plasmic/canvas_app_explorer/PlasmicAddRemoveButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,14 @@ function PlasmicAddRemoveButton__RenderFunc(props) {
const { variants, args, overrides, forNode } = props;
const $props = props.args;
return (
<div
<button
data-plasmic-name={"root"}
data-plasmic-override={overrides.root}
data-plasmic-root={true}
data-plasmic-for-node={forNode}
alt={
hasVariant(variants, "removeToolFromSite", "removeToolFromSite")
? "Remove this tool from your Canvas site"
: "Add this tool from your Canvas site"
}
className={classNames(
"plasmic_default__all",
"plasmic_default__div",
"plasmic_default__button",
"__wab_text",
"root_reset_mXv5TZ5SUPGRneH9RoMn6q",
"plasmic_default_styles",
Expand All @@ -63,7 +58,7 @@ function PlasmicAddRemoveButton__RenderFunc(props) {
{hasVariant(variants, "removeToolFromSite", "removeToolFromSite")
? "Remove Tool "
: "+ Add Tool"}
</div>
</button>
);
}

Expand Down
15 changes: 8 additions & 7 deletions frontend/components/plasmic/canvas_app_explorer/PlasmicProductCard.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,13 +359,13 @@
object-fit: contain;
}
.ProductCard__imglearnMoreWithAddRemove__iXegCliXrj {
max-width: 257px;
left: auto;
top: auto;
object-fit: contain;
height: 100%;
height: 125px;
width: 250px;
min-height: 0;
max-width: none;
flex-shrink: 0;
}
.ProductCard__imglearnMoreWithAddRemove__iXegCliXrj > picture > img {
object-fit: contain;
Expand Down Expand Up @@ -712,7 +712,7 @@
left: auto;
top: auto;
}
.ProductCard__findOutMoreContainer__yg7Mp {
.ProductCard__basicInfoContainer__yg7Mp {
display: flex;
position: relative;
flex-direction: column;
Expand All @@ -724,10 +724,10 @@
min-width: 0;
padding: 8px 15px;
}
.ProductCard__findOutMoreContainerlearnMore__yg7MpOklBv {
.ProductCard__basicInfoContainerlearnMore__yg7MpOklBv {
display: none;
}
.ProductCard__findOutMoreContainerlearnMoreWithAddRemove__yg7MpliXrj {
.ProductCard__basicInfoContainerlearnMoreWithAddRemove__yg7MpliXrj {
display: none;
}
.ProductCard__img___0SrCv {
Expand All @@ -747,11 +747,12 @@
object-fit: cover;
}
.ProductCard__imgwithoutScreenshotButtons___0SrCv5HQgZ {
max-width: 257px;
max-width: none;
height: 125px;
object-fit: contain;
left: auto;
top: auto;
width: 250px;
flex-shrink: 0;
}
.ProductCard__imgwithoutScreenshotButtons___0SrCv5HQgZ > picture > img {
Expand Down
51 changes: 32 additions & 19 deletions frontend/components/plasmic/canvas_app_explorer/PlasmicProductCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ export const PlasmicProductCard__ArgProps = new Array(
"photoLearnMore",
"logo",
"toolLearnMore",
"description"
"description",
"logoAltText",
"photoLearnMoreAltText"
);

function PlasmicProductCard__RenderFunc(props) {
Expand Down Expand Up @@ -671,13 +673,9 @@ function PlasmicProductCard__RenderFunc(props) {
>
<img
alt={
hasVariant(
variants,
"learnMoreWithAddRemove",
"learnMoreWithAddRemove"
)
? "Logo for tool"
: "Logo of Panopto"
args.logoAltText !== undefined
? args.logoAltText
: "Logo for tool"
}
className={classNames(
"plasmic_default__all",
Expand Down Expand Up @@ -1056,7 +1054,11 @@ function PlasmicProductCard__RenderFunc(props) {
)}
>
<img
alt={"Image showing what this tool looks like in use "}
alt={
args.photoLearnMoreAltText !== undefined
? args.photoLearnMoreAltText
: "Image showing what this tool looks like in use"
}
className={classNames(
"plasmic_default__all",
"plasmic_default__img",
Expand Down Expand Up @@ -1444,22 +1446,25 @@ function PlasmicProductCard__RenderFunc(props) {
: true
) ? (
<div
data-plasmic-name={"findOutMoreContainer"}
data-plasmic-override={overrides.findOutMoreContainer}
data-plasmic-name={"basicInfoContainer"}
data-plasmic-override={overrides.basicInfoContainer}
className={classNames(
"plasmic_default__all",
"plasmic_default__div",
"ProductCard__findOutMoreContainer__yg7Mp",
"ProductCard__basicInfoContainer__yg7Mp",
{
ProductCard__findOutMoreContainerlearnMoreWithAddRemove__yg7MpliXrj:
ProductCard__basicInfoContainerlearnMoreWithAddRemove__yg7MpliXrj:
hasVariant(
variants,
"learnMoreWithAddRemove",
"learnMoreWithAddRemove"
),

ProductCard__findOutMoreContainerlearnMore__yg7MpOklBv:
hasVariant(variants, "learnMore", "learnMore")
ProductCard__basicInfoContainerlearnMore__yg7MpOklBv: hasVariant(
variants,
"learnMore",
"learnMore"
)
}
)}
>
Expand Down Expand Up @@ -1495,7 +1500,15 @@ function PlasmicProductCard__RenderFunc(props) {
className={classNames(
"plasmic_default__all",
"plasmic_default__div",
"ProductCard__freeBox__fCpId"
"ProductCard__freeBox__fCpId",
{
ProductCard__freeBoxwithoutScreenshotButtons__fCpId5HQgZ:
hasVariant(
variants,
"withoutScreenshotButtons",
"withoutScreenshotButtons"
)
}
)}
>
{p.renderPlasmicSlot({
Expand Down Expand Up @@ -1603,13 +1616,13 @@ const PlasmicDescendants = {
"learnMoreTool",
"screenshotBackground",
"learnMoreInfoContainer",
"findOutMoreContainer"
"basicInfoContainer"
],

learnMoreTool: ["learnMoreTool"],
screenshotBackground: ["screenshotBackground"],
learnMoreInfoContainer: ["learnMoreInfoContainer"],
findOutMoreContainer: ["findOutMoreContainer"]
basicInfoContainer: ["basicInfoContainer"]
};

function makeNodeComponent(nodeName) {
Expand Down Expand Up @@ -1644,7 +1657,7 @@ export const PlasmicProductCard = Object.assign(
learnMoreTool: makeNodeComponent("learnMoreTool"),
screenshotBackground: makeNodeComponent("screenshotBackground"),
learnMoreInfoContainer: makeNodeComponent("learnMoreInfoContainer"),
findOutMoreContainer: makeNodeComponent("findOutMoreContainer"),
basicInfoContainer: makeNodeComponent("basicInfoContainer"),
// Metadata about props expected for PlasmicProductCard
internalVariantProps: PlasmicProductCard__VariantProps,
internalArgProps: PlasmicProductCard__ArgProps
Expand Down
8 changes: 4 additions & 4 deletions frontend/components/plasmic/canvas_app_explorer/PlasmicTitleLearnMoreButton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ function PlasmicTitleLearnMoreButton__RenderFunc(props) {
const { variants, args, overrides, forNode } = props;
const $props = props.args;
return (
<div
<button
data-plasmic-name={"root"}
data-plasmic-override={overrides.root}
data-plasmic-root={true}
data-plasmic-for-node={forNode}
alt={"Find out more about this tool"}
aria-label={""}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix this but I'll do it as part of the issue regarding the button text.

className={classNames(
"plasmic_default__all",
"plasmic_default__div",
"plasmic_default__button",
"root_reset_mXv5TZ5SUPGRneH9RoMn6q",
"plasmic_default_styles",
"plasmic_mixins",
Expand All @@ -51,7 +51,7 @@ function PlasmicTitleLearnMoreButton__RenderFunc(props) {
value: args.children,
className: classNames("TitleLearnMoreButton__slotTargetChildren__riL5Q")
})}
</div>
</button>
);
}

Expand Down
14 changes: 7 additions & 7 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"webpack-dev-server": "^3.0.0"
},
"dependencies": {
"@plasmicapp/cli": "^0.1.176",
"@plasmicapp/cli": "^0.1.178",
"@plasmicapp/react-web": "^0.2.95"
}
}
4 changes: 2 additions & 2 deletions frontend/plasmic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,6 @@
]
},
"wrapPagesWithGlobalContexts": true,
"cliVersion": "0.1.176",
"$schema": "https://unpkg.com/@plasmicapp/[email protected].176/dist/plasmic.schema.json"
"cliVersion": "0.1.178",
"$schema": "https://unpkg.com/@plasmicapp/[email protected].178/dist/plasmic.schema.json"
}
12 changes: 6 additions & 6 deletions frontend/plasmic.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@
{
"type": "renderModule",
"assetId": "zc_-JZqmkLhAk",
"checksum": "90cf9fa55030cb565ae55ba7ceb974cd"
"checksum": "d00cabbd22e3b543d79b0b0949b08ec7"
},
{
"type": "cssRules",
"assetId": "zc_-JZqmkLhAk",
"checksum": "90cf9fa55030cb565ae55ba7ceb974cd"
"checksum": "d00cabbd22e3b543d79b0b0949b08ec7"
},
{
"type": "renderModule",
Expand Down Expand Up @@ -110,12 +110,12 @@
{
"type": "renderModule",
"assetId": "JyIyDBiGW-",
"checksum": "cfb45776c0a2e943dcd2689d95fb199a"
"checksum": "a3549365219cbada281ecb53788e8b22"
},
{
"type": "cssRules",
"assetId": "JyIyDBiGW-",
"checksum": "cfb45776c0a2e943dcd2689d95fb199a"
"checksum": "a3549365219cbada281ecb53788e8b22"
},
{
"type": "renderModule",
Expand Down Expand Up @@ -330,12 +330,12 @@
{
"type": "renderModule",
"assetId": "oCDAnWtrIp",
"checksum": "40971b93df4f922bf3be472fb626d585"
"checksum": "c0f7495488dd2c5e235643958d8103f7"
},
{
"type": "cssRules",
"assetId": "oCDAnWtrIp",
"checksum": "40971b93df4f922bf3be472fb626d585"
"checksum": "c0f7495488dd2c5e235643958d8103f7"
},
{
"type": "icon",
Expand Down