Add a niceness option to the FFmpeg class initializer
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! There are other useful commands, such as "ionice" or "taskset". I think we could generalize this, by adding "modifier options" which would be appended at the start of FFMPeg.arguments. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Niceness allows a process to have a lower or higher priority on Unix-like systems, this is useful to prevent ffmpeg from hogging all CPU resources in case of multiple concurrent conversions.
This PR adds a
nicenessparameter to the FFmpeg class constructor, which sets the niceness of the ffmpeg process that will be spawned. It also works on Windows, throughcreationflagsand process priority.