refactor: update code examples

joseluisq · Mar 27, 2021 · b2d0ebb · b2d0ebb
1 parent 78d7897
commit b2d0ebb
Show file tree

Hide file tree

Showing 2 changed files with 63 additions and 30 deletions.
diff --git a/README.md b/README.md
@@ -81,15 +81,28 @@ func main() {
 				fmt.Printf("Cmd `%s` executed!\n", ctx.Cmd.Name)
 				fmt.Printf("App Flag `file` opted: `%s`\n", ctx.AppContext.Flags.Any("file"))
 
-				i, err := ctx.Flags.Int("trace").Value()
+				trace, err := ctx.Flags.Int("trace")
 				if err != nil {
-					fmt.Println(err)
-					os.Exit(1)
+					return err
 				}
+				i, err := trace.Value()
+				if err != nil {
+					return err
+				}
+
 				fmt.Printf("Cmd Flag `trace` opted: `%d` (%T)\n", i, i)
 
-				d, _ := ctx.Flags.Bool("detailed").Value()
+				detailed, err := ctx.Flags.Bool("detailed")
+				if err != nil {
+					return err
+				}
+				d, err := detailed.Value()
+				if err != nil {
+					return err
+				}
+
 				fmt.Printf("Cmd Flag `detailed` opted: `%v` (%T)\n", d, d)
+
 				fmt.Printf("Cmd Tail arguments: %#v\n", ctx.TailArgs)
 				return nil
 			},
@@ -98,11 +111,16 @@ func main() {
 	app.Handler = func(ctx *cli.AppContext) error {
 		fmt.Printf("App `%s` executed!\n", ctx.App.Name)
 		fmt.Printf("App Tail arguments: %#v\n", ctx.TailArgs)
-		fmt.Printf("App Flag `file` opted: `%v`\n", ctx.Flags.StringSlice("file"))
 
-		b, _ := ctx.Flags.Bool("verbose").Value()
+		if f, err := ctx.Flags.StringSlice("file"); err == nil {
+			fmt.Printf("App Flag `file` opted: `%v`\n", f.Value())
+		}
+
+		if v, err := ctx.Flags.Bool("verbose"); err == nil {
+			b, _ := v.Value()
+			fmt.Printf("App Flag `verbose` opted: `%v`\n", b)
+		}
 
-		fmt.Printf("App Flag `verbose` opted: `%v`\n", b)
 		return nil
 	}
 	if err := app.Run(os.Args); err != nil {

diff --git a/examples/main.go b/examples/main.go
@@ -72,28 +72,35 @@ func main() {
 			Handler: func(ctx *cli.CmdContext) error {
 				fmt.Printf("Cmd `%s` executed!\n", ctx.Cmd.Name)
 
-				if file, err := ctx.AppContext.Flags.String("file"); err != nil {
-					fmt.Printf("App Flag `file`: `%s`\n", file.Value())
+				file, err := ctx.AppContext.Flags.String("file")
+				if err != nil {
+					return err
 				}
+				fmt.Printf("App Flag `file`: `%s`\n", file.Value())
 
-				if verbose, err := ctx.AppContext.Flags.Bool("verbose"); err != nil {
-					b, _ := verbose.Value()
-					fmt.Printf("App Flag `verbose`: `%v`\n", b)
+				verbose, err := ctx.AppContext.Flags.Bool("verbose")
+				if err != nil {
+					return err
 				}
+				b, _ := verbose.Value()
+				fmt.Printf("App Flag `verbose`: `%v`\n", b)
 
-				if trace, err := ctx.AppContext.Flags.Int("trace"); err != nil {
-					i, err := trace.Value()
-					if err != nil {
-						fmt.Println(err)
-						os.Exit(1)
-					}
-					fmt.Printf("Cmd Flag `trace`: `%d` (%T)\n", i, i)
+				trace, err := ctx.AppContext.Flags.Int("trace")
+				if err != nil {
+					return err
+				}
+				i, err := trace.Value()
+				if err != nil {
+					return err
 				}
+				fmt.Printf("Cmd Flag `trace`: `%d` (%T)\n", i, i)
 
-				if detailed, err := ctx.AppContext.Flags.Bool("detailed"); err != nil {
-					d, _ := detailed.Value()
-					fmt.Printf("Cmd Flag `detailed`: `%v` (%T)\n", d, d)
+				detailed, err := ctx.AppContext.Flags.Bool("detailed")
+				if err != nil {
+					return err
 				}
+				d, _ := detailed.Value()
+				fmt.Printf("Cmd Flag `detailed`: `%v` (%T)\n", d, d)
 
 				fmt.Printf("Cmd Tail arguments: %#v\n", ctx.TailArgs)
 				return nil
@@ -103,19 +110,27 @@ func main() {
 	app.Handler = func(ctx *cli.AppContext) error {
 		fmt.Printf("App `%s` executed!\n", ctx.App.Name)
 
-		if file, err := ctx.Flags.Bool("file"); err != nil {
-			if b, err := file.Value(); err != nil {
-				fmt.Printf("App Flag `file`: `%t`\n", b)
-			}
+		file, err := ctx.Flags.String("file")
+		if err != nil {
+			return err
+		}
+		b := file.Value()
+		if err != nil {
+			return err
 		}
+		fmt.Printf("App Flag `file`: `%s`\n", b)
 
 		fmt.Printf("App Flag `int`: `%v`\n", ctx.Flags.Any("int"))
 
-		if verbose, err := ctx.Flags.Bool("verbose"); err != nil {
-			if b, err := verbose.Value(); err != nil {
-				fmt.Printf("App Flag `verbose`: `%v`\n", b)
-			}
+		verbose, err := ctx.Flags.Bool("verbose")
+		if err != nil {
+			return err
+		}
+		v, err := verbose.Value()
+		if err != nil {
+			return err
 		}
+		fmt.Printf("App Flag `verbose`: `%v`\n", v)
 
 		fmt.Printf("App Tail arguments: %#v\n", ctx.TailArgs)
 		fmt.Printf("App Provided flags: %v\n", ctx.Flags.GetProvided())