Clean

jqnatividad · Jun 14, 2014 · bc7e67a · bc7e67a
1 parent 808b307
commit bc7e67a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 14 deletions.
diff --git a/includes/parsers/CircleParser.php b/includes/parsers/CircleParser.php
@@ -17,10 +17,10 @@
  */
 class CircleParser extends StringValueParser {
 
-	protected $supportGeocoding = true;
+	private $supportGeocoding = true;
 
 	// TODO: use options
-	protected $metaDataSeparator = '~';
+	private $metaDataSeparator = '~';
 
 	/**
 	 * @see StringValueParser::stringParse
@@ -68,7 +68,7 @@ public function stringParse( $value ) {
 		return $circle;
 	}
 
-	protected function stringToLatLongValue( $location ) {
+	private function stringToLatLongValue( $location ) {
 		if ( $this->supportGeocoding && Geocoders::canGeocode() ) {
 			$location = Geocoders::attemptToGeocode( $location );
 

diff --git a/includes/parsers/LocationParser.php b/includes/parsers/LocationParser.php
@@ -21,7 +21,7 @@
 class LocationParser extends StringValueParser {
 
 	// TODO
-	protected $supportGeocoding = true;
+	private $supportGeocoding = true;
 
 	/**
 	 * @see StringValueParser::stringParse
@@ -65,7 +65,7 @@ public function stringParse( $value ) {
 		return $location;
 	}
 
-	protected function setTitleOrLink( Location $location, $titleOrLink ) {
+	private function setTitleOrLink( Location $location, $titleOrLink ) {
 		if ( $this->isLink( $titleOrLink ) ) {
 			$this->setLink( $location, $titleOrLink );
 		}
@@ -74,16 +74,16 @@ protected function setTitleOrLink( Location $location, $titleOrLink ) {
 		}
 	}
 
-	protected function isLink( $value ) {
+	private function isLink( $value ) {
 		return strpos( $value , 'link:' ) === 0;
 	}
 
-	protected function setLink( Location $location, $link ) {
+	private function setLink( Location $location, $link ) {
 		$link = substr( $link, 5 );
 		$location->setLink( $this->getExpandedLink( $link ) );
 	}
 
-	protected function getExpandedLink( $link ) {
+	private function getExpandedLink( $link ) {
 		if ( filter_var( $link , FILTER_VALIDATE_URL , FILTER_FLAG_SCHEME_REQUIRED ) ) {
 			return $link;
 		}
@@ -98,14 +98,12 @@ protected function getExpandedLink( $link ) {
 	}
 
 	/**
-	 * @since 3.0
-	 *
 	 * @param string $location
 	 *
 	 * @return LatLongValue
 	 * @throws ParseException
 	 */
-	protected function stringToLatLongValue( $location ) {
+	private function stringToLatLongValue( $location ) {
 		if ( $this->supportGeocoding && Geocoders::canGeocode() ) {
 			$location = Geocoders::attemptToGeocode( $location );
 

diff --git a/includes/parsers/RectangleParser.php b/includes/parsers/RectangleParser.php
@@ -17,10 +17,10 @@
  */
 class RectangleParser extends StringValueParser {
 
-	protected $supportGeocoding = true;
+	private $supportGeocoding = true;
 
 	// TODO: use options
-	protected $metaDataSeparator = '~';
+	private $metaDataSeparator = '~';
 
 	/**
 	 * @see StringValueParser::stringParse
@@ -63,7 +63,7 @@ public function stringParse( $value ) {
 		return $rectangle;
 	}
 
-	protected function stringToLatLongValue( $location ) {
+	private function stringToLatLongValue( $location ) {
 		if ( $this->supportGeocoding && Geocoders::canGeocode() ) {
 			$location = Geocoders::attemptToGeocode( $location );
 

diff --git a/includes/parsers/WmsOverlayParser.php b/includes/parsers/WmsOverlayParser.php
@@ -24,6 +24,7 @@ class WmsOverlayParser extends StringValueParser {
 	 * @param string $value
 	 *
 	 * @return WmsOverlay
+	 * @throws ParseException
 	 */
 	protected function stringParse( $value ) {
 		$separator = " ";