InternalEdgeRemovingCollector wasn't copying early out fraction on init

NarrowPhaseQuery::CastRay was updating instead of resetting the early out fraction (this can trigger an assert in case the initial hit fraction > 1)
jrouwe · Mar 8, 2025 · bbdece3 · bbdece3
1 parent 3f62f22
commit bbdece3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Jolt/Physics/Collision/InternalEdgeRemovingCollector.h b/Jolt/Physics/Collision/InternalEdgeRemovingCollector.h
@@ -77,6 +77,7 @@ class InternalEdgeRemovingCollector : public CollideShapeCollector
 public:
 	/// Constructor, configures a collector to be called with all the results that do not hit internal edges
 	explicit				InternalEdgeRemovingCollector(CollideShapeCollector &inChainedCollector) :
+		CollideShapeCollector(inChainedCollector),
 		mChainedCollector(inChainedCollector)
 	{
 		// Initialize arrays to full capacity to avoid needless reallocation calls

diff --git a/Jolt/Physics/Collision/NarrowPhaseQuery.cpp b/Jolt/Physics/Collision/NarrowPhaseQuery.cpp
@@ -29,7 +29,7 @@ bool NarrowPhaseQuery::CastRay(const RRayCast &inRay, RayCastResult &ioHit, cons
 			mBodyLockInterface(inBodyLockInterface),
 			mBodyFilter(inBodyFilter)
 		{
-			UpdateEarlyOutFraction(ioHit.mFraction);
+			ResetEarlyOutFraction(ioHit.mFraction);
 		}
 
 		virtual void		AddHit(const ResultType &inResult) override