Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using native type arithmetic (no more codegen!) #184

Merged
merged 1 commit into from
May 17, 2024

Conversation

jscheiny
Copy link
Owner

@jscheiny jscheiny commented May 17, 2024

This PR removes the old clunky code gen to compute multiplication, addition, and subtraction tables. Now we do this all natively in typescript using fun tuple math!

Note this generally is a good thing and largely removes the exponent restrictions previously in place. However, to make this work I decided to ditch some of the exponentiation and root functionality. This PR has the following breaking changes:

  • Exponents are now represented as numbers instead of strings
  • Removed all square root / cube root / nth root functionality (e.g. functions like sqrt() and cbrt())
  • Removed arbitrary exponentiation (toThe(power) is gone). All that is left is squared() and cubed() which now just work all the time!

@jscheiny jscheiny merged commit 5185d1c into master May 17, 2024
2 checks passed
@jscheiny jscheiny deleted the raw-exponents branch May 17, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant