fix cli tool from crashing when handling author URL input; add changeset

jspsych · Jan 30, 2025 · ec57500 · ec57500
1 parent 0040c6e
commit ec57500
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/fifty-tables-nail.md b/.changeset/fifty-tables-nail.md
@@ -0,0 +1,7 @@
+---
+"@jspsych/new-extension": patch
+"@jspsych/new-timeline": patch
+"@jspsych/new-plugin": patch
+---
+
+This patch fixes the getGitHttpsUrl(await getRemoteGitUrl()) call in cli.js of the new-plugin, new-extension and new-timeline packages so that this line does not crash from calling getGitHttpsUrl() on a promise.
diff --git a/packages/new-extension/src/cli.js b/packages/new-extension/src/cli.js
@@ -146,9 +146,10 @@ async function runPrompts(cwdInfo) {
   // If not in the jspsych-contrib repository, ask for the path to the README.md file
   let readmePath;
   if (!cwdInfo.isContribRepo) {
+    const remoteGitUrl = await getRemoteGitUrl();
     readmePath = await input({
       message: "Enter the path to the README.md file for this extension package [Optional]:",
-      default: `${getGitHttpsUrl(await getRemoteGitUrl())}/extension-${name}/README.md`, // '/extension-${name}/README.md' if not a Git repository
+      default: `${getGitHttpsUrl(remoteGitUrl)}/extension-${name}/README.md`, // '/extension-${name}/README.md' if not a Git repository
     });
   } else {
     readmePath = `https://github.com/jspsych/jspsych-contrib/packages/extension-${name}/README.md`;

diff --git a/packages/new-timeline/src/cli.js b/packages/new-timeline/src/cli.js
@@ -145,10 +145,11 @@ async function runPrompts(cwdInfo) {
 
   // If not in the jspsych-timelines repository, ask for the path to the README.md file
   let readmePath;
+  const remoteGitUrl = await getRemoteGitUrl();
   if (!cwdInfo.isTimelinesRepo) {
     readmePath = await input({
       message: "Enter the path to the README.md file for this timeline package [Optional]:",
-      default: `${getGitHttpsUrl(await getRemoteGitUrl())}/timeline-${name}/README.md`, // '/timeline-${name}/README.md' if not a Git repository
+      default: `${getGitHttpsUrl(remoteGitUrl)}/timeline-${name}/README.md`, // '/timeline-${name}/README.md' if not a Git repository
     });
   } else {
     readmePath = `https://github.com/jspsych/jspsych-timelines/packages/timeline-${name}/README.md`;