Code

Add Notification support#446

Code

Draft

andrii-i wants to merge 75 commits intojupyter-server:mainjupyter-server/jupyter-scheduler:mainfrom andrii-i:notificationsandrii-i/jupyter-scheduler:notificationsCopy head branch name to clipboard

+499-43

Commits

Commits on Nov 1, 2023

• Add NotificationEvent Enum

  andrii-i

  committed
  73a938b

  Copy full SHA for 73a938b

• Mention enum in the docstring

  andrii-i

  committed
  b37aa2b

  Copy full SHA for b37aa2b

• add Notification class

  andrii-i

  committed
  2ff82d4

  Copy full SHA for 2ff82d4

• Add notification-related fields to RuntimeEnv

  andrii-i

  committed
  ce7d5e1

  Copy full SHA for ce7d5e1

• add notification field to JobDef models

  andrii-i

  committed
  3bbfd76

  Copy full SHA for 3bbfd76

• add notification to Job models

  andrii-i

  committed
  cf70931

  Copy full SHA for cf70931

• add notification to Job and JobDef orm classes

  andrii-i

  committed
  04a9bc8

  Copy full SHA for 04a9bc8

• add __str__ to NotificationEvent

  andrii-i

  committed
  199be36

  Copy full SHA for 199be36

• add notifications to front-end models

  andrii-i

  committed
  bedc97f

  Copy full SHA for bedc97f

• add BaseModel to Notification class

  andrii-i

  committed
  276188e

  Copy full SHA for 276188e

• make NotificationEvent a StrEnum

  andrii-i

  committed
  6eea203

  Copy full SHA for 6eea203

• use list comprehension for notification_events

  andrii-i

  committed
  3ed5f7f

  Copy full SHA for 3ed5f7f

• create notitifactions-picker component

  andrii-i

  committed
  c473c6c

  Copy full SHA for c473c6c

• add notifications_picker to create-job

  andrii-i

  committed
  98731d9

  Copy full SHA for 98731d9

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for b341f49
  

  pre-commit-ci[bot]

  authored and

  andrii-i

  committed
  b341f49

  Copy full SHA for b341f49

• add NotificationsPicker component

  andrii-i

  committed
  011a315

  Copy full SHA for 011a315

• ad NotificationsPicker to create job form

  andrii-i

  committed
  d58fb03

  Copy full SHA for d58fb03

• add Notification type, use it in ICreateJobModel

  andrii-i

  committed
  bfdde0d

  Copy full SHA for bfdde0d

• disable notifications by default

  andrii-i

  committed
  7e4237c

  Copy full SHA for 7e4237c

• code formatriing

  andrii-i

  committed
  873882f

  Copy full SHA for 873882f

• Use (str, Enum) not StrEnum to work w Python <3.11

  andrii-i

  committed
  415f9e3

  Copy full SHA for 415f9e3

• addd notification events chips

  andrii-i

  committed
  1e157ec

  Copy full SHA for 1e157ec

• use NotificationPicker

  andrii-i

  committed
  be04bf6

  Copy full SHA for be04bf6

• make sendTo optional and add enableNotification to models

  andrii-i

  committed
  dca3492

  Copy full SHA for dca3492

• account for sendTo being optional

  andrii-i

  committed
  d331ad8

  Copy full SHA for d331ad8

• add enable notifications toggle

  andrii-i

  committed
  d86a6f4

  Copy full SHA for d86a6f4

• make sendTo a string[] in all models

  andrii-i

  committed
  702dec1

  Copy full SHA for 702dec1

• save sendTo input to model on blur or on enter

  andrii-i

  committed
  e002bf6

  Copy full SHA for e002bf6

• add option to Include Output

  andrii-i

  committed
  9fc56b6

  Copy full SHA for 9fc56b6

• use Notification, not Notifications in UI elements

  andrii-i

  committed
  766a2e6

  Copy full SHA for 766a2e6

• add notification to detail models

  andrii-i

  committed
  a191dda

  Copy full SHA for a191dda

• check if enableNotification and set it if not

  andrii-i

  committed
  a933dc4

  Copy full SHA for a933dc4

• display notification info in JobDetail

  andrii-i

  committed
  bbb5bb6

  Copy full SHA for bbb5bb6

• clean-up code

  andrii-i

  committed
  32eb7f6

  Copy full SHA for 32eb7f6

• Update Send To, Event indexes to start from 1

  andrii-i

  committed
  5a1fa30

  Copy full SHA for 5a1fa30

• set notifications_enabled to False by default

  andrii-i

  committed
  eaa6bc9

  Copy full SHA for eaa6bc9

• add attrib-s description to Notification, NotificationEvent

  andrii-i

  committed
  e9ddade

  Copy full SHA for e9ddade

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for b0a0f5a
  

  pre-commit-ci[bot]

  authored and

  andrii-i

  committed
  b0a0f5a

  Copy full SHA for b0a0f5a

• adjust docstring

  andrii-i

  committed
  b77d3b1

  Copy full SHA for b77d3b1

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for 2eb0507
  

  pre-commit-ci[bot]

  authored and

  andrii-i

  committed
  2eb0507

  Copy full SHA for 2eb0507

• default notification_events to []

  andrii-i

  committed
  52c6aa1

  Copy full SHA for 52c6aa1

• rename "Notification" into "NotificationSettings"

  andrii-i

  committed
  8a417bc

  Copy full SHA for 8a417bc

• Rename INotification --> INotificationsSettings

  andrii-i

  committed
  6ee5055

  Copy full SHA for 6ee5055

• run prettier

  andrii-i

  committed
  848b71e

  Copy full SHA for 848b71e

• update local var names to notificationsSettings

  andrii-i

  committed
  57f6a75

  Copy full SHA for 57f6a75

• convert props to types from interfaces

  andrii-i

  committed
  b07e516

  Copy full SHA for b07e516

• Use Sentence case, not Title Case for field labels

  andrii-i

  committed
  711ca24

  Copy full SHA for 711ca24

• conver arrow functions into plain old functions, move props type declarations into separate types

  andrii-i

  committed
  878bca5

  Copy full SHA for 878bca5

• extract SelectedEventsChips props type into a separate type declaration

  andrii-i

  committed
  f200838

  Copy full SHA for f200838

• NotificationsSettings --> NotificationsConfig

  andrii-i

  committed
  319fa80

  Copy full SHA for 319fa80

• rename NotificationsSettings --> NotificationsConfig

  andrii-i

  committed
  be78d8b

  Copy full SHA for be78d8b

• notifications_settings --> notifications_config

  andrii-i

  committed
  142f444

  Copy full SHA for 142f444

• rename INotificationsConfigDetailProps

  andrii-i

  committed
  c8acf42

  Copy full SHA for c8acf42

• make NotificationsConfig a separate table

  andrii-i

  committed
  eb0a72a

  Copy full SHA for eb0a72a

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for c68d7cf
  

  pre-commit-ci[bot]

  authored and

  andrii-i

  committed
  c68d7cf

  Copy full SHA for c68d7cf

• change validator signature

  andrii-i

  committed
  63ce389

  Copy full SHA for 63ce389

• add pydantic validators

  andrii-i

  committed
  1401b86

  Copy full SHA for 1401b86

• correct validator function naming

  andrii-i

  committed
  041ba11

  Copy full SHA for 041ba11

• eager load NotificationsConfig relationship by default

  andrii-i

  committed
  e63c507

  Copy full SHA for e63c507

• Utilize more targeted model update function for NotificationsConfig

  andrii-i

  committed
  95204d7

  Copy full SHA for 95204d7

• convert NotificationsConfig to dict

  andrii-i

  committed
  8757418

  Copy full SHA for 8757418

• adjust RuntimeEnvironment

  andrii-i

  committed
  3503123

  Copy full SHA for 3503123

• fix orm to pydantic model conversion

  andrii-i

  committed
  9b3ca4f

  Copy full SHA for 9b3ca4f

• [pre-commit.ci] auto fixes from pre-commit.com hooks

  Show description for d905ff5
  

  pre-commit-ci[bot]

  authored and

  andrii-i

  committed
  d905ff5

  Copy full SHA for d905ff5

• fix notifications config pydantic to orm data conversion for create_job_def

  andrii-i

  committed
  1696c51

  Copy full SHA for 1696c51

Commits on Nov 2, 2023

• use props.model.notificationsConfig as a basis for NotificationsConfig state

  andrii-i

  committed
  740bad8

  Copy full SHA for 740bad8

• remove useCallback to simplify as no perf gains

  andrii-i

  committed
  711e3d5

  Copy full SHA for 711e3d5

• adjust SelectedEventsChips's onChange

  andrii-i

  committed
  3ef4269

  Copy full SHA for 3ef4269

• fix chip delete function

  andrii-i

  committed
  2e1b2f8

  Copy full SHA for 2e1b2f8

• remove test defaults

  andrii-i

  committed
  c434fca

  Copy full SHA for c434fca

• Display "Send to" and "Notification events" as Chips

  andrii-i

  committed
  02dccfe

  Copy full SHA for 02dccfe

• remvoe NotificationsConfigItem

  andrii-i

  committed
  29331cf

  Copy full SHA for 29331cf

• use LabeledValue for all Notifications Settings items

  andrii-i

  committed
  7002908

  Copy full SHA for 7002908

• represent events as comma-separated list

  andrii-i

  committed
  10b3239

  Copy full SHA for 10b3239

• display send to as a comma-separated list of strings in details

  andrii-i

  committed
  24f9fdb

  Copy full SHA for 24f9fdb