-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version flag #385
base: main
Are you sure you want to change the base?
Add version flag #385
Conversation
Goreleaser adds ldflags:
- -s -w -X powerline.Version={{.Version}} to |
@dex4er I was not able to get a relative import path to work. Only the fully qualified import path works.
Do you get the same results? If you do, can the PR able to be merged as is? |
@justjanne Can you accept this PR? It will help us to verify if correct version of powerline-go is installed. Also it will simplify my CI test for https://github.com/dex4er/asdf-powerline-go |
@dex4er I'll look into it this weekend. I'll try to find some time to make a few changes to powerline-go in the next week anyway, a version flag would definitely be part of that^^ |
Did you get a chance to look at it? I made a pull request to @marklap's branch to sync all changes made, it'd be cool to get this PR merged given the value:LoC of it. If there are issues with the implementation itself I'd be happy to help change it or open a new PR on @marklap's behalf if they are too busy. I understand if you have too much on your hands already to spend a ton of energy on it yourself! |
Intended to add support for a version flag that is updated automatically at build time (and reflected in the build artifacts). Disclaimer: I know nothing about goreleaser so my assumptions may be bad and more work on this PR may be needed. Of course I'm happy to do the work, but some guidance from someone more familiar with goreleaser would be much appreciated.
ref: #78