Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix omitEmpty is not propagated #90

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix omitEmpty is not propagated #90

merged 2 commits into from
Nov 27, 2024

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Nov 27, 2024 •
edited
Loading

I've found omitEmpty (#89) is not propagated in (*printer).format(). It is a bug in nested struct with SetOmitEmpty().

k0kubun
k0kubun approved these changes Nov 27, 2024
View reviewed changes
Copy link
Owner

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k0kubun k0kubun merged commit fe205da into k0kubun:master Nov 27, 2024
8 checks passed
@apstndb apstndb deleted the fix/omit-empty branch November 27, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apstndb @k0kubun