-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript support (entry level only) #49
Conversation
Hi Thank you so much for your contributions! Adding TypeScript to AgenticJS is a significant enhancement that will undoubtedly benefit many developers. I’ve reviewed your pull request and have a few suggestions. Your expertise is truly valuable to us, and your efforts are greatly appreciated. Please know that these suggestions are meant to build on the fantastic foundation you’ve already laid, without any pressure.
Thank you again for your hard work and dedication. I’m here to support you in any way I can. |
Nice. |
Hi @darielnoel To add the types it has to be declared as a separate package I am not sure yet how to produce a proper distributable output yet using rollup. (except as an external type package) |
Hi @alienkarma, Thank you for the quick updates and for adding the JSDocs along with the Node.js TypeScript example. 🤗 Could you provide the steps required to set up and run the Node.js TypeScript example locally? (Maybe adding a Readme.md with the steps is a good idea?) P.S: I know running such examples can be complex without the module being available on npm. However, I'm confident we can figure out an effective workaround together. Thanks again for your hard work and dedication! |
I will work on making a build setup script going (for both dev and production purpose). |
Thank you @alienkarma, I'm sorry for the back and forth. Just trying to make sure that every feature we add has a solid foundation. Here's some of the philosophy we are trying to pursue. Thanks for your patience and understanding 🤗 |
Very much looking for TypeScript friendlyness; it really helps diving into a new codebase. |
- Added typescript package builder - Updated node-ts playground example
Hi @darielnoel As always, let me know if any changes/feedback. (I really appreciate it 😄) |
…ound example updated
- Replaced dts-generator with rollup-dts plugin. - Used npm link to link packages locally for playground testing - Simplified bundle outputs and scripts - Modified package json exports to reflect the same - Fixed unnecessary typing references
… extensions accordingly.
Attempt to fix issue #41 Enhance Public AgenticJS API TypeScript