-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shinigami Script Editor Playground #290
base: main
Are you sure you want to change the base?
Shinigami Script Editor Playground #290
Conversation
@supreme2580 is attempting to deploy a commit to the keep-starknet-strange Team on Vercel. A member of the Team first needs to authorize it. |
I tried running locally, and changed the script a bit to result in an error, but I still got a "1" as the stack after running. I changed the first OP_1 to OP_2. |
@b-j-roberts Hey boss, so what I did is for it to return 1 if the execution is successful and 0 if it is not |
@b-j-roberts Also boss when if [0,0] should mean that the execution failed, I ran it on Bitcoin IDE OP_1 OP_2 or 1 2 and I got the same result as shinigami.ts |
Do you mean when you run it, it should show the entire stack, then when you debug it should go step by step? |
Btw, I don't recommend merging main into your branch. Looks like there was some errors introduced on the run scripts which were merged in |
Oh... and I used results from run_script.sh to judge the results lol, what'd you recommend? |
Sorry, using run_script.sh should be good still. This script gives different results when running with the script and frontend shinigami though: |
Okay let me test this |
Yes I see, one value is missing, let me check that out |
30dc455
to
a143408
Compare
Wrote the shinigami script execution logic in typescript to enable instant script execution and debugging in the shinigami script editor in shinigami.ts
Confirmed that results from the shinigami cairo implementation and the shinigami typescript implementation returns the same values
[DOES NOT USE CAIRO WASM]
Closes: #240