Base Updates. Fixes lite bins. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added additional assertions.
* Simplified. * More readable. * Prevents gaps that could be left by old logic. (rounded_square)
Also move constants to standard.scad.
Simplifies code for gridfinityBase, and prepares for future work.
* Fix Cura not creating interior. (magic slice too thin) * Add a base_outer_shell module. * Use base_outer_shell to create the vase mode base.
Use a completely different method to generate both the keep out zone and the base.
Ruudjhuu
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-worked the base creation code. Again...
Lite bins now look like this (3x3 base, 2x2 compartments):
The lite bases don't have quite as many options as the regular bins. However for the simple case this should be a nice solution. It also massively simplifies the code.
I am thinking of moving base generation code to a separate file, but this is good enough for the moment.