Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_config to BruteForceRetrieval layer. #15

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

hertschuh
Copy link
Collaborator

For consistency with other layers. Note that this does not serialize candidates.

Copy link
Collaborator

@abheesht17 abheesht17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you think we can remove the name arg (passed to __init__)? kwargs will subsume it

@hertschuh
Copy link
Collaborator Author

Looks good. Do you think we can remove the name arg (passed to __init__)? kwargs will subsume it

Oh, sure, I'll change it now

For consistency with other layers. Note that this does not serialize candidates.

Also removed explicit `name` argument in `__init__`.
@hertschuh hertschuh merged commit 5164294 into keras-team:main Jan 28, 2025
5 checks passed
@hertschuh hertschuh deleted the brute_force_config branch January 28, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants