Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export useMediaQuery hook #282

Merged
merged 1 commit into from
Jan 2, 2020
Merged

export useMediaQuery hook #282

merged 1 commit into from
Jan 2, 2020

Conversation

ruhaise
Copy link
Collaborator

@ruhaise ruhaise commented Jan 2, 2020 •
edited by kettanaito
Loading

Changes

  • exported useMediaQuery hook so that library users can use this hook as
    import { useMediaQuery } from 'atomic-layout'
  • add documentation for this in hooks https://redd.gitbook.io/atomic-layout/api/hooks

GitHub

Release version

  • patch (internal improvements)
  • minor (backward-compatible changes)
  • major (breaking, backward-incompatible changes)

Contributor's checklist

  • My branch is up-to-date with the latest master
  • I ran yarn verify and verified the build and tests passing

@ruhaise ruhaise requested a review from kettanaito January 2, 2020 15:26
@ruhaise
Copy link
Collaborator Author

ruhaise commented Jan 2, 2020

@kettanaito could you kindly add documentation for this since we have this issue #237

@ruhaise ruhaise force-pushed the 280-export-use-mediaquery branch from 2a28904 to a69783a Compare January 2, 2020 15:55
@ruhaise ruhaise requested a review from kettanaito January 2, 2020 15:56
kettanaito
kettanaito approved these changes Jan 2, 2020
View reviewed changes
Copy link
Owner

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Feel free to merge, I'll update the docs meanwhile.

@kettanaito
Copy link
Owner

Added Hooks > useMediaQuery page.

@kettanaito kettanaito merged commit b18fbf0 into master Jan 2, 2020
@kettanaito kettanaito deleted the 280-export-use-mediaquery branch January 2, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kettanaito kettanaito kettanaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make internal useMediaQuery public
2 participants
@ruhaise @kettanaito