Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add ability to add stem type(s) #412

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

sillypears
Copy link
Contributor

Let's maintainers add the type of stem used for each colorway. Thought about adding a default of MX but realized this was probably a bad idea. Letting maintainers add MX for their caps is required, along with any other stem type used for each colorweay.

I tested this in ways I thought needed to be but I think it should be verified, I only really tested with my own catalog

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@anhthang
Copy link
Collaborator

anhthang commented Jan 3, 2025

is this done? should i merge the PR

@anhthang anhthang merged commit 6dd8eba into keycap-archivist:master Jan 4, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants