Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize add-version.sh script to allow versioning other repos #563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Generalize add-version.sh script to allow versioning other repos #563

wants to merge 1 commit into from

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Feb 6, 2025

Closes #562

@jonkoops jonkoops requested review from mposolda and stianst February 6, 2025 13:09
mposolda
mposolda approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

It is backwards compatible and uses keycloak by default when no other argument sent to add-version script, so should not require any changes in keycloak-rel AFAIK, which is good.

@jonkoops
Copy link
Contributor Author

jonkoops commented Feb 7, 2025

Yes, the idea was to keep it backwards compatible to avoid having to update the releases. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mposolda mposolda mposolda approved these changes

@stianst stianst Awaiting requested review from stianst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize add-version.sh to be able to target other repositories
2 participants
@jonkoops @mposolda