Merge pull request #75 from kinde-oss/fix/audiencecheck

fix: audience check when checking specific
kinde-oss · Sep 27, 2024 · 35cf719 · 35cf719
2 parents 6036573 + be35291
commit 35cf719
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/src/utils/isTokenValid/isIDTokenValid.test.ts b/src/utils/isTokenValid/isIDTokenValid.test.ts
@@ -115,6 +115,21 @@ describe('isIDToken valid', () => {
     );
   });
 
+  test("Extra aud values don't throw", () => {
+    expect(
+      isTokenValid(
+        {
+          header,
+          payload: {
+            ...idTokenStub,
+            aud: ['https://account.acme.com', '123456789']
+          }
+        },
+        config
+      )
+    ).toBe(true);
+  });
+
   test('Throw error if token expired', () => {
     expect(() => {
       isTokenValid(

diff --git a/src/utils/isTokenValid/isTokenValid.ts b/src/utils/isTokenValid/isTokenValid.ts
@@ -29,11 +29,13 @@ const isTokenValid = (token: any, config: any) => {
       throw new Error('(aud) claim must be an array');
     }
 
-    if (
-      !token.payload.aud.every((element: string) =>
-        config.aud.includes(element)
-      )
-    ) {
+    const configAud = config.aud.split(' ');
+
+    const allConfigAudExistInPayload = configAud.every((element: string) =>
+      token.payload.aud.includes(element)
+    );
+
+    if (!allConfigAudExistInPayload) {
       throw new Error(
         `(aud) claim mismatch. Expected: "${
           config.aud