-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update start_page
to spec prompt
#63
Conversation
WalkthroughThe recent update involves a significant change in the terminology and functionality related to redirection and prompting actions. Specifically, the term Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- src/createKindeClient.ts (4 hunks)
- src/types.ts (1 hunks)
Additional comments: 4
src/types.ts (1)
- 93-93: The change from
start_page
toprompt
within theRedirectOptions
type aligns with the PR objectives. Ensure that all references to thestart_page
property across the project are updated toprompt
.Verification successful
The search for any remaining references to 'start_page' did not produce any output, indicating that all references have likely been updated to 'prompt' as intended. This aligns with the PR objectives and suggests that the change has been successfully implemented across the project.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining references to 'start_page' that should be updated to 'prompt'. rg --type ts 'start_page'Length of output: 25
src/createKindeClient.ts (3)
- 380-380: The update to set
prompt
to 'create' in theregister
function aligns with the PR objectives and should enhance the user experience by providing more context-specific prompts during registration.- 393-393: The update to set
prompt
to 'create' andis_create_org
to true in thecreateOrg
function aligns with the PR objectives and should enhance the user experience by making the organization creation process more intuitive.- 346-347: The conditional handling of the
prompt
parameter in theredirectToKinde
function is a flexible approach that allows for customization of prompts based on the context. This should enhance the user experience by providing more relevant prompts in different scenarios.
Summary
OAuth spec now accepts
create
as an argument to theprompt
param to indicate a registration. Updated SDK to use thisChecklist
🛟 If you need help, consider asking for advice over in the Kinde community.
Summary by CodeRabbit