[Critical] Fix refresh_token

[faforty]

Unable to refresh token due to incorrect declaration in request.

[coderabbitai]

Walkthrough

The createKindeClient function in src/createKindeClient.ts has been modified to rename the localStorageRefreshToken key to refresh_token in the object passed to the API. This change ensures consistency with API expectations and simplifies the handling of tokens.

Changes

File	Change Summary
src/createKindeClient.ts	Renamed localStorageRefreshToken to refresh_token in the object passed to the API within the createKindeClient function.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

src/createKindeClient.ts (1)

Line range hint 1-239:
Consider checking for missing required options.

The function could benefit from additional validation to ensure all required options are provided and valid before proceeding with the client initialization.

+ const requiredOptions = ['audience', 'client_id', 'domain', 'redirect_uri'];
+ requiredOptions.forEach((opt) => {
+   if (!options[opt]) {
+     throw Error(`Missing required option: ${opt}`);
+   }
+ });

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f43af70 and 271ab83.

Files selected for processing (1)

• src/createKindeClient.ts (1 hunks)

Additional comments not posted (1)

src/createKindeClient.ts (1)

187-188: LGTM! Ensure correctness with the API documentation.

The change correctly renames localStorageRefreshToken to refresh_token in the fetch request body. This aligns with typical API requirements for refresh tokens.

However, verify if this matches the expected parameter name in the API documentation.

Verification successful

---

Verified!

The parameter name refresh_token is consistently used across the repository, indicating that the change made in src/createKindeClient.ts aligns with the existing codebase.

• src/createKindeClient.ts: Multiple occurrences confirming the usage of refresh_token.
• src/types.ts: Defined as a string type.
• src/constants/index.ts: Defined as a constant.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the parameter name `refresh_token` against the API documentation.

# Test: Search for `refresh_token` usage in the repository to ensure consistency.
rg --type md 'refresh_token'

Length of output: 28

---

Script:

#!/bin/bash
# Description: Verify the parameter name `refresh_token` in TypeScript and JavaScript files.

# Test: Search for `refresh_token` usage in the repository to ensure consistency.
rg --type ts 'refresh_token'
rg --type js 'refresh_token'

Length of output: 940

[DaveOrDead]

Legend thanks @faforty