Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/event validation #19

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feature/event validation #19

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
34b4677
Data validation
DankaMarci May 28, 2024
b3e83aa
Validation fixes
DankaMarci May 28, 2024
76a675a
Adds required packages
csiszaralex Jun 4, 2024
39098df
dto and entity fixes
DankaMarci Jun 5, 2024
d3b6244
rand fix
DankaMarci Jun 5, 2024
3102e7a
Merge branch 'feature/event-validation' of https://github.com/kir-dev…
DankaMarci Jun 5, 2024
9c5ce14
Conflict and event entity fixes
DankaMarci Jun 7, 2024
4f05111
rquested changes on the Event dto
DankaMarci Jun 21, 2024
ef883f1
Requested fixes on the Event DTO
DankaMarci Sep 27, 2024
59eadf9
Merge branch 'main' into feature/event-validation
DankaMarci Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/backend/src/event/dto/create-event.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ import { OmitType } from '@nestjs/swagger';

import { Event } from '../entities/event.entity';

export class CreateEventDto extends OmitType(Event, ['id', 'category', 'ownerGroupId', 'ownerUserId']) {}
export class CreateEventDto extends OmitType(Event, ['ownerGroupId', 'ownerUserId']) {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omit only id, because that's the only information the database comes up with alone. The owner we should specify.

8 changes: 2 additions & 6 deletions apps/backend/src/event/entities/event.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,18 @@ export class Category {
id: number;

@IsString()
@IsNotEmpty()
name: string;
balintking marked this conversation as resolved.
Show resolved Hide resolved

@IsString()
@IsOptional()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsOptional() should stay as well, sorry if I wasn't clear

color: string;
color?: string;

@IsString()
@IsOptional()
description: string;
}
export class Event {
@IsInt()
@IsOptional()
id: number;

@IsString()
Expand Down Expand Up @@ -58,11 +57,8 @@ export class Event {
status: Status;

@IsInt()
@IsOptional()
categoryId: number;

category: Category;

@IsInt()
ownerUserId: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional


Expand Down