added posts crud #14
Merged
added posts crud #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isti01
reviewed
Jul 16, 2024
| id, | ||
| }, | ||
| }); | ||
| if (currentPost.authorId !== user.authSchId && user.role !== 'BODY_ADMIN') { |
There was a problem hiding this comment.
Is it a good idea to only allow the original author to edit/delete posts?
| id, | ||
| }, | ||
| }); | ||
| if (currentPost.authorId !== user.authSchId && user.role !== 'BODY_ADMIN') { |
Tschonti
reviewed
Jul 23, 2024
Comment on lines
44
to
59
| async update(id: number, updatePostDto: UpdatePostDto) { | ||
| return this.prisma.post.update({ | ||
| where: { | ||
| id, | ||
| }, | ||
| data: updatePostDto, | ||
| }); | ||
| } | ||
|
|
||
| async remove(id: number) { | ||
| return this.prisma.post.delete({ | ||
| where: { | ||
| id, | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
prisma update and delete methods throw an exception if no record is found, we should catch so no 500 error is thrown
Tschonti
reviewed
Aug 5, 2024
Tschonti
requested changes
Aug 13, 2024
Comment on lines
34
to
50
| try { | ||
| return this.prisma.post.findUniqueOrThrow({ | ||
| where: { | ||
| id, | ||
| }, | ||
| include: { | ||
| author: true, | ||
| }, | ||
| }); | ||
| } catch (e) { | ||
| if (e instanceof Prisma.PrismaClientKnownRequestError) { | ||
| if (e.code === 'P2025') { | ||
| throw new NotFoundException('This post does not exist.'); | ||
| } | ||
| throw new InternalServerErrorException('An error occurred.'); | ||
| } | ||
| } |
There was a problem hiding this comment.
classic mistake: trying to catch an error in an async call without awaiting it
Comment on lines
75
to
92
| try { | ||
| return this.prisma.post.delete({ | ||
| where: { | ||
| id, | ||
| }, | ||
| }); | ||
| } catch (e) { | ||
| if (e instanceof Prisma.PrismaClientKnownRequestError) { | ||
| switch (e.code) { | ||
| case 'P2000': | ||
| throw new BadRequestException('The content is too long.'); | ||
| case 'P2025': | ||
| throw new NotFoundException('This post does not exist.'); | ||
| } | ||
| } | ||
| throw new InternalServerErrorException('An error occurred.'); | ||
| } | ||
| } |
Tschonti
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2