added basic crud for application periods #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tschonti
requested changes
Aug 13, 2024
apps/backend/src/application-period/application-period.service.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+34
to
+62
| @UseGuards(AuthGuard('jwt'), RolesGuard) | ||
| @ApiBearerAuth() | ||
| @Roles(Role.BODY_ADMIN, Role.BODY_MEMBER) | ||
| @Post() | ||
| async create( | ||
| @Body() createApplicationPeriodDto: CreateApplicationPeriodDto, | ||
| @CurrentUser() user: User | ||
| ): Promise<ApplicationPeriod> { | ||
| return this.applicationPeriodService.create(createApplicationPeriodDto, user); | ||
| } | ||
|
|
||
| @UseGuards(AuthGuard('jwt'), RolesGuard) | ||
| @ApiBearerAuth() | ||
| @Roles(Role.BODY_ADMIN, Role.BODY_MEMBER) | ||
| @Delete(':id') | ||
| async delete(@Param('id') id: string): Promise<ApplicationPeriod> { | ||
| return this.applicationPeriodService.delete(Number(id)); | ||
| } | ||
|
|
||
| @UseGuards(AuthGuard('jwt'), RolesGuard) | ||
| @ApiBearerAuth() | ||
| @Roles(Role.BODY_ADMIN, Role.BODY_MEMBER) | ||
| @Patch(':id') | ||
| async update( | ||
| @Body() updateApplicationPeriodDto: UpdateApplicationPeriodDto, | ||
| @Param() id: string | ||
| ): Promise<ApplicationPeriod> { | ||
| return this.applicationPeriodService.update(updateApplicationPeriodDto, Number(id)); | ||
| } |
There was a problem hiding this comment.
not sure if this was discussed with them, but maybe it'd make sense if only the body admin could do these
Comment on lines
+19
to
+32
| @Get() | ||
| async findAll(@Query() getApplicationPeriodsDto: GetApplicationPeriodsDto): Promise<SimpleApplicationPeriodDto[]> { | ||
| return this.applicationPeriodService.findAll(getApplicationPeriodsDto); | ||
| } | ||
|
|
||
| @Get('current') | ||
| async getCurrentPeriod(): Promise<ApplicationPeriod> { | ||
| return this.applicationPeriodService.getCurrentPeriod(); | ||
| } | ||
|
|
||
| @Get(':id') | ||
| async findOne(@Param('id') id: string): Promise<ApplicationPeriod> { | ||
| return this.applicationPeriodService.findOne(Number(id)); | ||
| } |
There was a problem hiding this comment.
do regular users need access to the findAll and findOne methods?
There was a problem hiding this comment.
I don't really see the point of them not seeing it. But we should discuss the permissions regardless
apps/backend/src/application-period/application-period.service.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/application-period/application-period.service.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/application-period/application-period.service.ts
Outdated
Show resolved
Hide resolved
Tschonti
approved these changes
Aug 13, 2024
|
On the create-application dto I don't see any validation, aren't those needed? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Sry, dunno, why I thought it was #4, so the branch name is wrong.
It seems to be quite painful to fetch all application periods for checking the overlaps. Maybe we can reconsider this.