Skip to content
This repository has been archived by the owner on Aug 31, 2024. It is now read-only.

Update README.md #37

Merged
merged 3 commits into from
Nov 20, 2015
Merged

Update README.md #37

merged 3 commits into from
Nov 20, 2015

Conversation

xie-qianyue
Copy link
Contributor

figure out that the exercises are only verified under koa 1, but not koa 2.

figure out that exercises are not verified under koa 2.
@hemanth
Copy link
Member

hemanth commented Nov 19, 2015

Any specific issues you noticed?

@xie-qianyue
Copy link
Contributor Author

@hemanth yes, please see this issue. I'm not sure whether it concerns the version, but as @dead-horse says, maybe it's the version problem.

@hemanth
Copy link
Member

hemanth commented Nov 20, 2015

Hmm, rather than updating the readme, it's better we migrate to 2.0 it be nice if you could modify the text to something like:

Note that the exercises of kick-off are only verified under koa 1, but NOT koa 2. Meanwhile we are migrating to kao 2 and you can also take part in it.

@tejasmanohar
Copy link
Member

👍 for what @hemanth said since we do want to have Koa 2 stuff eventually too :)

@xie-qianyue
Copy link
Contributor Author

@hemanth I have modified the READ ME as you proposed. I will test the exercises under koa 2. If I find something wrong, I will create the issue.

@hemanth
Copy link
Member

hemanth commented Nov 20, 2015

@xie-qianyue Cool, thanks.

Please have a single issue with checklists.

hemanth added a commit that referenced this pull request Nov 20, 2015
@hemanth hemanth merged commit 0845459 into koajs:master Nov 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants