Add sqlite database for storing shared agent data; store and monitor startup data #1515
Conversation
RebeccaMahany
force-pushed
the
becca/startup-info
branch
from
416e2d1 to
618000c
Compare
RebeccaMahany
changed the title
RebeccaMahany
changed the title
RebeccaMahany
force-pushed
the
becca/startup-info
branch
from
aa73c87 to
d1d9867
Compare
| conn, err := sql.Open("sqlite", dbLocation(rootDirectory)) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("opening startup db in %s: %w", rootDirectory, err) | ||
| } |
There was a problem hiding this comment.
What should happen if the file doesn't exist? (I'm honestly not sure)
Should OpenRO return something with nils? Return an error and let the caller handle it? I guess letting the caller handle it is correct
There was a problem hiding this comment.
Related -- we might want validateDb in here?
There was a problem hiding this comment.
You'd asked for the RO option to be more lightweight and to skip the validation when we'd discussed on slack, since we need to use the RO option early on in launcher startup.
There was a problem hiding this comment.
I was thinking about skipping migration -- I'm less sure what should happen if the DB file isn't present. Or doesn't match expected schema. Bailing early and getting nothing isn't wrong
There was a problem hiding this comment.
I guess that's probably the right way to look at it -- If the DB is wrong, we should bail out and get nothing. Maybe it doesn't exist yet, maybe it hasn't been udpated to the current schema. So whatever we need to catch that and move on
There was a problem hiding this comment.
👍 I will handle that in the next PR that starts to use the RO connection
RebeccaMahany
dismissed stale reviews from directionless and James-Pickett
via
238fd17
The new
startuppackage monitors the flags that it's registered to observe, and updates them in a shared sqlite database on change. It also allows for querying for these flags outside of the launcher root context. This will be useful on launcher startup, when we need to pull autoupdate-related settings before we haveknapsackavailable.The new
agentsqlitedatabase is a partial implementation of a KVStore -- I only added Get/Set/Update, since that was what was required for the newstartuppackage.