Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate enrollment details on launcher startup #2068

Merged
merged 35 commits into from
Feb 8, 2025
Merged

Conversation

cesarfda
Copy link
Contributor

@cesarfda cesarfda commented Jan 27, 2025

This pull request introduces several changes to the osquery and launcher package to handle enrollment details.

  • enrollment details are now getting triggered from runLauncher
  • details are stored in the knapsack
  • extension will poll until details are ready for enrollment
  • if osquery details fails, extension will enroll with only runtime details to avoid unknown device type error
  • osquery version gets refreshed anytime we try to get the details from knapsack, avoiding changes to AutoUpdater to cover the version update for the details.

Closes #1986

Enrollment Details Handling:

Interface and Mock Updates:

Interface Updates:

Miscellaneous:

@cesarfda cesarfda marked this pull request as ready for review January 30, 2025 15:52
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple small nitpicks!

RebeccaMahany
RebeccaMahany previously approved these changes Feb 4, 2025
Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! (I don't know if @directionless wanted to review again before merge?)

James-Pickett
James-Pickett previously approved these changes Feb 5, 2025
@James-Pickett James-Pickett requested review from James-Pickett and removed request for James-Pickett February 5, 2025 18:04
@James-Pickett James-Pickett dismissed their stale review February 5, 2025 18:07

Accidentally hit approve

@cesarfda cesarfda enabled auto-merge February 7, 2025 16:49
@cesarfda cesarfda disabled auto-merge February 7, 2025 16:49
@cesarfda cesarfda added this pull request to the merge queue Feb 8, 2025
Merged via the queue into main with commit 45f58f9 Feb 8, 2025
31 of 32 checks passed
@cesarfda cesarfda deleted the enrollment-details-2 branch February 8, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include enrollment details in /id response
3 participants