-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate enrollment details on launcher startup #2068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple small nitpicks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! (I don't know if @directionless wanted to review again before merge?)
Co-authored-by: James Pickett <[email protected]>
This pull request introduces several changes to the
osquery
andlauncher
package to handle enrollment details.Closes #1986
Enrollment Details Handling:
cmd/launcher/launcher.go
: Added a call toosquery.CollectAndSetEnrollmentDetails
to collect and set enrollment details during the launcher run.ee/agent/knapsack/knapsack.go
: Added methodsSetEnrollmentDetails
andGetEnrollmentDetails
to manage enrollment details.ee/agent/types/enrollment.go
: IntroducedEnrollmentDetails
struct constants to encapsulate enrollment information.Interface and Mock Updates:
ee/agent/types/knapsack.go
: UpdatedKnapsack
interface to includeGetEnrollmentDetails
andSetEnrollmentDetails
methods.ee/agent/types/mocks/knapsack.go
: Updated mock functions to support newKVStore
type and added mocks forGetEnrollmentDetails
andSetEnrollmentDetails
. [1] [2] [3] [4]Interface Updates:
ee/agent/types/knapsack.go
: Updated theKnapsack
interface to includeGetEnrollmentDetails
andSetEnrollmentDetails
methods.Miscellaneous:
ee/agent/types/status.go
: Removed redundantEnrollmentStatus
type definitions.