-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check munemo in local server #2095
Merged
James-Pickett
merged 7 commits into
kolide:main
from
James-Pickett:james/local-server-munemo-match
Feb 14, 2025
Merged
check munemo in local server #2095
James-Pickett
merged 7 commits into
kolide:main
from
James-Pickett:james/local-server-munemo-match
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code seems great to me just a couple questions/comments:
|
Yea, I'm cool with caching the munemo, probably in knapsack ... or perhaps just on the local server struct so we only parse once |
zackattack01
reviewed
Feb 7, 2025
zackattack01
reviewed
Feb 7, 2025
zackattack01
previously approved these changes
Feb 7, 2025
zackattack01
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handler to local server to reject requests that don't match munemo from enroll secret.
This should stop the issue where presence detection window get "refreshed" because 2 launcher instances are trying to do presence detection in Kolide's dual launcher set up.
corresponding k2 pr https://github.com/kolide/k2/pull/11339