remove unneeded rsa references, upgrade krypto #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
changed the title
directionless
previously approved these changes
Feb 11, 2025
There was a problem hiding this comment.
What about
launcher/pkg/osquery/extension.go
Line 221 in df315fe
James-Pickett
commented
Feb 11, 2025
zackattack01
previously approved these changes
Feb 11, 2025
| // There are 3 keys: | ||
| // 1. The RSA key. This is stored in the launcher DB, and was the first key used by krypto. We are deprecating it. | ||
| // 2. The hardware keys -- these are in the secure enclave (TPM or Apple's thing) These are used to identify the device | ||
| // 3. The launcher install key -- this is an ECC key that is sometimes used in conjunction with (2) |
There was a problem hiding this comment.
I think this comment is old -- we don't generate the ECC keys in this function. Thus it's removal is safe
cesarfda
previously approved these changes
Feb 12, 2025
James-Pickett
dismissed stale reviews from cesarfda and zackattack01
via
8b9811b
zackattack01
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K2 & Krypto PRs
https://github.com/kolide/k2/pull/11371
kolide/krypto#47