Refactor trace exporter to utilize enrollment details from knapsack #2122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
TraceExporter
class and related tests, focusing on removing the dependency on theosqueryClient
and refactoring the way attributes are added from enrollment details.Resolves #2076
Refactoring
TraceExporter
:osqueryClient
dependency fromTraceExporter
and related methods. (pkg/traces/exporter/exporter.go
) [1] [2]addAttributesFromOsquery
to use enrollment details instead of queryingosquery
. (pkg/traces/exporter/exporter.go
)TraceExporter
to calladdAttributesFromOsquery
directly. (pkg/traces/exporter/exporter.go
)Test Updates:
osqueryClient
from tests. (pkg/traces/exporter/exporter_test.go
) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]GetEnrollmentDetails
for providing necessary attributes. (pkg/traces/exporter/exporter_test.go
) [1] [2] [3]Minor Cleanup:
pkg/traces/exporter/exporter.go
) [1] [2] [3]SetOsqueryClient
method and related calls. (pkg/traces/exporter/exporter.go
)These changes streamline the
TraceExporter
class by eliminating the need for anosqueryClient
and leveraging enrollment details directly, simplifying the code and improving maintainability.