Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow origin (in requests to /zta) to be missing or empty #2127

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Allow origin (in requests to /zta) to be missing or empty #2127

merged 1 commit into from
Feb 26, 2025

Conversation

RebeccaMahany
Copy link
Contributor

We only want to disallow requests where the origin is set and it isn't in the allowlist.

directionless
directionless approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't love the nesting, but good enough!

@RebeccaMahany RebeccaMahany added this pull request to the merge queue Feb 26, 2025
Merged via the queue into kolide:main with commit f99e64f Feb 26, 2025
33 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/allow-missing-empty-origins branch February 26, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebeccaMahany @directionless