Skip to content

Commit

Permalink
DEL-2330 Rename method to clarify its purpose
Browse files Browse the repository at this point in the history
  • Loading branch information
Tobias Kamenicky authored and Tobias Kamenicky committed Nov 12, 2019
1 parent fb5b00f commit 60b346b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public void ExtractParameters_WhenGivenTypeWithCodenameAndExistingParams_AddsCod
{
var existingParams = new List<IQueryParameter>() { new SkipParameter(15) };

var enhancedParams = new List<IQueryParameter>(_client.ExtractParameters<TypeWithContentTypeCodename>(existingParams));
var enhancedParams = new List<IQueryParameter>(_client.EnsureContentTypeFilter<TypeWithContentTypeCodename>(existingParams));

Assert.Equal(2, enhancedParams.Count);
Assert.True(enhancedParams.Find(x => x.GetQueryStringParameter() == $"system.type={CONTENT_TYPE_CODENAME}") != null);
Expand All @@ -58,7 +58,7 @@ public void ExtractParameters_WhenGivenTypeWithCodenameAndExistingParams_AddsCod
[Fact]
public void ExtractParameters_WhenGivenTypeWithCodename_CreatesNewParams()
{
var enhancedParams = new List<IQueryParameter>(_client.ExtractParameters<TypeWithContentTypeCodename>());
var enhancedParams = new List<IQueryParameter>(_client.EnsureContentTypeFilter<TypeWithContentTypeCodename>());

Assert.Single(enhancedParams);
Assert.True(enhancedParams.Find(x => x.GetQueryStringParameter() == $"system.type={CONTENT_TYPE_CODENAME}") != null);
Expand All @@ -67,7 +67,7 @@ public void ExtractParameters_WhenGivenTypeWithCodename_CreatesNewParams()
[Fact]
public void ExtractParameters_WhenGivenTypeWithoutCodenameNoParams_CreatesEmptyParams()
{
var enhancedParams = new List<IQueryParameter>(_client.ExtractParameters<TypeWithoutContentTypeCodename>());
var enhancedParams = new List<IQueryParameter>(_client.EnsureContentTypeFilter<TypeWithoutContentTypeCodename>());

Assert.Empty(enhancedParams);
}
Expand All @@ -77,7 +77,7 @@ public void ExtractParameters_WhenGivenTypeWithoutCodenameAndParams_ReturnsParam
{
var existingParams = new List<IQueryParameter>() { new SkipParameter(15) };

var enhancedParams = new List<IQueryParameter>(_client.ExtractParameters<TypeWithoutContentTypeCodename>(existingParams));
var enhancedParams = new List<IQueryParameter>(_client.EnsureContentTypeFilter<TypeWithoutContentTypeCodename>(existingParams));

Assert.Single(enhancedParams);
Assert.True(enhancedParams.Find(x => x.GetQueryStringParameter() == $"system.type=TypeWithoutContentTypeCodename") == null);
Expand All @@ -88,7 +88,7 @@ public void ExtractParameters_WhenGivenTypeWithCodenameAndExistingTypeParameter_
{
var existingParams = new List<IQueryParameter>() { new EqualsFilter("system.type", CONTENT_TYPE_CODENAME) };

var enhancedParams = new List<IQueryParameter>(_client.ExtractParameters<TypeWithContentTypeCodename>(existingParams));
var enhancedParams = new List<IQueryParameter>(_client.EnsureContentTypeFilter<TypeWithContentTypeCodename>(existingParams));

Assert.Single(enhancedParams);
Assert.True(enhancedParams.Find(x => x.GetQueryStringParameter() == $"system.type={CONTENT_TYPE_CODENAME}") != null);
Expand Down
6 changes: 3 additions & 3 deletions Kentico.Kontent.Delivery/DeliveryClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public async Task<DeliveryItemListingResponse<T>> GetItemsAsync<T>(params IQuery
/// <returns>The <see cref="DeliveryItemListingResponse{T}"/> instance that contains the content items. If no query parameters are specified, all content items are returned.</returns>
public async Task<DeliveryItemListingResponse<T>> GetItemsAsync<T>(IEnumerable<IQueryParameter> parameters)
{
var enhancedParameters = ExtractParameters<T>(parameters).ToList();
var enhancedParameters = EnsureContentTypeFilter<T>(parameters).ToList();
var endpointUrl = UrlBuilder.GetItemsUrl(enhancedParameters);
var response = await GetDeliverResponseAsync(endpointUrl);

Expand Down Expand Up @@ -261,7 +261,7 @@ public IDeliveryItemsFeed<T> GetItemsFeed<T>(params IQueryParameter[] parameters
/// <returns>The <see cref="DeliveryItemsFeed{T}"/> instance that can be used to enumerate through content items. If no query parameters are specified, all content items are enumerated.</returns>
public IDeliveryItemsFeed<T> GetItemsFeed<T>(IEnumerable<IQueryParameter> parameters)
{
var enhancedParameters = ExtractParameters<T>(parameters).ToList();
var enhancedParameters = EnsureContentTypeFilter<T>(parameters).ToList();
ValidateItemsFeedParameters(enhancedParameters);
var endpointUrl = UrlBuilder.GetItemsFeedUrl(enhancedParameters);
return new DeliveryItemsFeed<T>(GetItemsBatchAsync);
Expand Down Expand Up @@ -555,7 +555,7 @@ private bool HasStaleContent(HttpResponseMessage httpResponseMessage)
return httpResponseMessage.Headers.TryGetValues("X-Stale-Content", out var values) && values.Contains("1", StringComparer.Ordinal);
}

internal IEnumerable<IQueryParameter> ExtractParameters<T>(IEnumerable<IQueryParameter> parameters = null)
internal IEnumerable<IQueryParameter> EnsureContentTypeFilter<T>(IEnumerable<IQueryParameter> parameters = null)
{
var enhancedParameters = parameters != null
? new List<IQueryParameter>(parameters)
Expand Down

0 comments on commit 60b346b

Please sign in to comment.