Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the port forward being cancelled #224

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Nov 30, 2023

It's ok for serve_forever to be cancelled.

Also added a little sleep to handle calling pf.start() and pf.stop() in quick succession.

Closes #221

@github-actions github-actions bot added the kr8s label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (0280954) 94.99% compared to head (c28aca1) 94.76%.
Report is 2 commits behind head on main.

Files Patch % Lines
kr8s/portforward.py 50.00% 5 Missing ⚠️
kr8s/_portforward.py 33.33% 2 Missing ⚠️
kr8s/tests/test_gen.py 90.47% 2 Missing ⚠️
kr8s/_objects.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   94.99%   94.76%   -0.23%     
==========================================
  Files          26       27       +1     
  Lines        2579     2638      +59     
==========================================
+ Hits         2450     2500      +50     
- Misses        129      138       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit ef96441 into kr8s-org:main Nov 30, 2023
8 of 9 checks passed
@jacobtomlinson jacobtomlinson deleted the sync-pf-stop-cancelled branch November 30, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portforward "stop" causes a "base" error.
1 participant