Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on getting api-resources instead of failing #231

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

jacobtomlinson
Copy link
Member

This might close #230.

When we list resources we try and look up API resources in order to expand short names. However, if the API call to get the resource list fails we could still continue and just raise a warning instead of an exception.

This means when the API call fails you can't use short names to look up resources, but you can still use full names.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4e87c09) 94.79% compared to head (95e5d49) 94.76%.

❗ Current head 95e5d49 differs from pull request most recent head eebb6ca. Consider uploading reports for the commit eebb6ca to get more accurate results

Files Patch % Lines
kr8s/_api.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   94.79%   94.76%   -0.03%     
==========================================
  Files          27       27              
  Lines        2669     2673       +4     
==========================================
+ Hits         2530     2533       +3     
- Misses        139      140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 092469a into kr8s-org:main Dec 5, 2023
7 checks passed
@jacobtomlinson jacobtomlinson deleted the warn-api-resources branch December 5, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to fetch namespaces if metrics service is unavailable at this moment
1 participant