Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify validate example #238

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Dec 11, 2023

kubernetes-validate>=1.28.1 now supports passing objects like kr8s.objects.Pod directly to kubernetes_validate.validate() so this PR simplifies the documentation example.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (092469a) 94.69% compared to head (a8bbf98) 94.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   94.69%   94.13%   -0.57%     
==========================================
  Files          27       27              
  Lines        2675     2675              
==========================================
- Hits         2533     2518      -15     
- Misses        142      157      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit ca26c5e into kr8s-org:main Dec 11, 2023
9 checks passed
@jacobtomlinson jacobtomlinson deleted the validate-simplify branch December 11, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant