Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum version of Python to 3.9 and httpx-ws to 0.7.0 #546

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jan 7, 2025

In #543 we are seeing an issue with the websocket ping conflicting with our interactions with the websocket. It looks like it was fixed upstream in frankie567/httpx-ws#89 and released in httpx-ws version 0.7.0.

This PR bumps our minimum version to ensure we get that fix.

This version of httpx-ws doesn't support Python 3.8 so this feels like a good opportunity to bump out minimum Python version to 3.9.

Closes #543

@github-actions github-actions bot added the ci label Jan 7, 2025
@jacobtomlinson
Copy link
Member Author

Looks like this change didn't trigger CI correctly so I've tweaked the GitHub Actions workflow to trigger properly.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (87063fc) to head (f4c8014).
Report is 155 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   94.61%   95.03%   +0.41%     
==========================================
  Files          29       30       +1     
  Lines        3141     4065     +924     
==========================================
+ Hits         2972     3863     +891     
- Misses        169      202      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson
Copy link
Member Author

It looks like httpx-ws 0.7.0 dropped support for Python 3.8. There are also other 3.8 related failures popping up so it feels like now is to good time for us to drop 3.8 too.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 7, 2025
@jacobtomlinson jacobtomlinson changed the title Bump minimum version of httpx-ws to 0.7.0 Bump minimum version of Python to 3.9 and httpx-ws to 0.7.0 Jan 7, 2025
@jacobtomlinson jacobtomlinson removed the documentation Improvements or additions to documentation label Jan 7, 2025
@jacobtomlinson jacobtomlinson merged commit ce3e0ac into kr8s-org:main Jan 7, 2025
20 checks passed
@jacobtomlinson jacobtomlinson deleted the httpx-ws-0-7-0 branch January 7, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anyio.BusyResourceError on port forward
1 participant