Fix Custom Resource pagination hang #547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #523 to close #544.
In #544 we are observing a hang when listing custom resources. It appears that built in resources omit the
continue
metadata parameter when reaching the end of the list, so we were testing for that to decide when to finish paging. However for custom resoureces it still includes thecontinue
paratmeter but just returns an empty string. This was resulting in us paging forever.This PR extends the check to ensure the
continue
parameter contains a value. I've also added come fixtures to make it easier to create and test custom resources in the future.