-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade K8s and Go versions #462
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4c81f97
to
c62ea3d
Compare
c378985
to
bf1f3de
Compare
Signed-off-by: WillardHu <[email protected]>
Signed-off-by: WillardHu <[email protected]>
Signed-off-by: WillardHu <[email protected]>
a499d11
to
8d8d949
Compare
I split the changes into 5 commits for easier review.
|
e634b66
to
f4dd5da
Compare
Signed-off-by: WillardHu <[email protected]>
Signed-off-by: WillardHu <[email protected]>
f4dd5da
to
86cf2b8
Compare
Could you also help change the version of the |
…KubeEdge Signed-off-by: WillardHu <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was golint removed and revive introduced in the linters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golint is no longer supported in golangci-lint
|
||
# Check if Sedna home is different from the standard directory where GO projects are located | ||
if ! [[ "${GOPATH}/src/${SEDNA_GO_PACKAGE}/" -ef "${SEDNA_ROOT}/" ]]; then | ||
# Copy generated code into SEDNA_ROOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the following if
logic removed because Sedna uses Go modules
, thus eliminating the need for GOPATH
?
if ! [[ "${GOPATH}/src/${SEDNA_GO_PACKAGE}/" -ef "${SEDNA_ROOT}/" ]]; then
# Copy generated code into SEDNA_ROOT
echo "Warning: ${SEDNA_ROOT} not included in $GOPATH which is required by code-gen"
echo "Moving generated code from ${GOPATH}/src/${SEDNA_GO_PACKAGE}/pkg/ to ${SEDNA_ROOT}/"
rsync -a ${GOPATH}/src/${SEDNA_GO_PACKAGE}/pkg/{client,apis} ${SEDNA_ROOT}/pkg
if [ $? -eq 0 ]; then
echo "Copy successful!"
rm -rf ${GOPATH}/src/${SEDNA_GO_PACKAGE}/pkg/{client,apis}
else
echo "Error during copy of the generated code!" >&2
fi
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new versions of client-gen, lister-gen and informer-gen tools can specify the output directory through the --output-dir
flag.
Thank you very much for your contribution. After the above issues are resolved, I'll give an "LGTM". |
cc @MooreZheng |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Update the versions of k8s and golang to keep consistent with the latest version of kubeedge.
Which issue(s) this PR fixes:
Fixes #