-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade docsy and hugo + add theme toggle #3973
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: milinddethe15 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @milinddethe15. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: milinddethe15 <[email protected]>
Signed-off-by: milinddethe15 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
upgrades the versions of docsy to
v0.10.0
and hugo tov0.125.4
hugo
anddocsy
version (add dark theme) #3954Based on suggestions received in #3968.
Preview link: https://deploy-preview-3973--competent-brattain-de2d6d.netlify.app/
This upgrade added some issues in layouts. If the team/community wants to go ahead with this upgrade, I can try fixing those issues.